Re: [libvirt] [PATCH] python: add virDomainGetCPUStats python binding API
On Wed, Mar 14, 2012 at 03:10:46AM -0600, Eric Blake wrote:
On 03/14/2012 03:02 AM, Daniel Veillard wrote:
> On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
>> On 03/14/2012 01:57 PM, Guannan Ren wrote:
>>> dom.cPUStats(True, 0)
>> I'd like getVcpuStats or cpuStats function naming.
>
> Based on existing conventions, it should be getVcpuStats() method,
getVcpuStats is wrong - if flags is 0, we are getting stats on the
physical cpu of the host, not the vcpu of the guest.
I think we want getCpuStats.
oops, right
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/