On Tue, Aug 26, 2025 at 09:33:59 -0500, Praveen K Paladugu wrote:
On 8/25/2025 3:22 PM, Peter Krempa wrote:
On Mon, Aug 25, 2025 at 10:57:52 -0500, Praveen K Paladugu wrote:
Introduce mshv variant in capabilities tests.
Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com> --- .../caps_11.3.0_x86_64+mshv.replies | 46912 ++++++++++++++++ .../caps_11.3.0_x86_64+mshv.xml | 4996 ++ .../qemucaps2xmloutdata/caps.x86_64+mshv.xml | 29 + 3 files changed, 51937 insertions(+) create mode 100644 tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.replies create mode 100644 tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.xml create mode 100644 tests/qemucaps2xmloutdata/caps.x86_64+mshv.xml
Few issues:
1) the test-suite fails after this patch:
$ VIR_TEST_REGENERATE_OUTPUT=1 ./tests/domaincapstest TEST: domaincapstest ............................../home/pipo/libvirt/tests/domaincapsdata/qemu_11.3.0.x86_64+mshv.xml: failed to open: No such file or directory !/home/pipo/libvirt/tests/domaincapsdata/qemu_11.3.0-q35.x86_64+mshv.xml: failed to open: No such file or directory !/home/pipo/libvirt/tests/domaincapsdata/qemu_11.3.0-tcg.x86_64+mshv.xml: failed to open: No such file or directory !....... 40 .................................. 74 FAIL 3 tests failed. Run them using: VIR_TEST_DEBUG=1 VIR_TEST_RANGE=31-33 ./tests/domaincapstest
You seem to have forgotten to commit the two output files.
I didn't notice this failure among the other failures I am seeing with this test locally. I will investigate this further.
Can you elaborate what other failures you are seeing? Also note that reviewer bandwidth is limited, so posting patches that you know don't pass the test suite consumes from the available review bandwidth possibly delaying further reviews.
2) the filename of the caps dump is wrong:
diff --git a/tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.replies b/tests/qemucapabilitiesdata/caps_11.3.0_x86_64+mshv.replies
The upcoming qemu version is 10.1 so you can't really have qemu-11.3 at this point.
I noticed some files with caps_10.1.0_x86_64*** versioning. As Qemu version 10.1 was not released, I assumed this is libvirt version.
We do use capabilities from the in-development version to stay on top of upcoming changes. As said if you want to add a capability dump from the current qemu development cycle you need to update it once the appropriate qemu version is released. The filename is documented in tests/qemucapabilitiesdata/README.rst I've mentioned in my reply to your first posting where you asked about capabilities. Also the current in-dev libvirt version is 11.7 so using '11.3' by that logic wouldnt' make sense either.