Re: [libvirt] Please help confirm this upsream issue

On 08/07/2013 03:41 AM, Daniel P. Berrange wrote: Although the question was poorly worded by referring to downstream elements, I still think the concept behind the question is appropriate for upstream. That is: What good is the "rename-restart" <on_*> XML element? Is it wired up for anything other than xen? A grep of the code base shows only: src/conf/domain_conf.h: VIR_DOMAIN_LIFECYCLE_RESTART_RENAME, src/conf/domain_conf.h: VIR_DOMAIN_LIFECYCLE_CRASH_RESTART_RENAME, src/nwfilter/nwfilter_ebiptables_driver.c:#define NWFILTER_FUNC_RENAME_CHAINS ebiptables_script_func_rename_chains src/nwfilter/nwfilter_ebiptables_driver.c: virBufferAsprintf(buf, NWFILTER_FUNC_RENAME_CHAINS, src/qemu/qemu_driver.c: vm->def->onPoweroff == VIR_DOMAIN_LIFECYCLE_RESTART_RENAME) { src/test/test_driver.c: case VIR_DOMAIN_LIFECYCLE_RESTART_RENAME: src/xenapi/xenapi_utils.c: else if (action == VIR_DOMAIN_LIFECYCLE_CRASH_RESTART_RENAME) src/xenapi/xenapi_utils.c: num = XEN_ON_CRASH_BEHAVIOUR_RENAME_RESTART; src/xenapi/xenapi_utils.c: else if (action == XEN_ON_CRASH_BEHAVIOUR_RENAME_RESTART) src/xenapi/xenapi_utils.c: num = VIR_DOMAIN_LIFECYCLE_CRASH_RESTART_RENAME; which looks like only xen has wired up the ability to automatically rename a domain when restarting it. If so, we ought to update formatdomain.html to better clarify that not all actions are supported for all hypervisors. (Hmm, that page already admits that <on_poweroff>rename-restart</on_poweroff> is treated like plain 'restart' for qemu/kvm; so really the question is whether we copied that behavior for the new support for <on_crash>). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org