Re: [libvirt] [PATCH v3 08/16] conf, schema: add support for memnode elements

On 07/16/2014 12:33 PM, Martin Kletzander wrote: > On Wed, Jul 16, 2014 at 12:21:24PM -0600, Eric Blake wrote: >> On 07/16/2014 08:42 AM, Martin Kletzander wrote: >>> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; >>> --- > [...] >> >> Missing an <interleave> here (<memory> and <memnode> should be swappable >> with one another). >> > > Oh! My bad. So sorry :-( > > Good point, is this OK to push as trivial (git diff -w): Count this as my ACK :)

> > diff --git i/docs/schemas/domaincommon.rng w/docs/schemas/domaincommon.rng > index a0ea300..fb5bdb3 100644 > --- i/docs/schemas/domaincommon.rng > +++ w/docs/schemas/domaincommon.rng > @@ -790,6 +790,7 @@ > </element> > </optional> > <zeroOrMore> > + <interleave> > <element name="memnode"> I'm assuming the odd spacing here is due to pasting into the email body, not how it actually looked in the diff. That, and diff -w already plays games with spacing.