Re: [libvirt PATCH 000/351] port libvirt to Meson build system

On Thu, Jul 16, 2020 at 11:53:56AM +0200, Pavel Hrdina wrote: > So I was finally able to produce the patches to port libvirt to Meson. > Obviously, it is a lot of changes. It might look that some of the > patches could be squashed together but I would rather have it as > separated as possible to make the review not that difficult. Some things I noticed, building on Fedora 31, with meson 0.55 from pip A bunch of warnings from meson: WARNING: custom_target 'virtesxgen' has more than one output! Using the first one. WARNING: custom_target 'virthypervgen' has more than one output! Using the first one. WARNING: custom_target 'protocol.h' has more than one output! Using the first one. WARNING: custom_target 'generate-api' has more than one output! Using the first one. WARNING: custom_target 'index-api' has more than one output! Using the first one. WARNING: custom_target 'index-admin-api' has more than one output! Using the first one. WARNING: custom_target 'index-lxc-api' has more than one output! Using the first one. WARNING: custom_target 'index-qemu-api' has more than one output! Using the first one.

During build, a bunch of bogus automake style progress messages: Generating virtesxgen with a custom command GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_types.generated.typedef GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_types.generated.typeenum GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_types.generated.typetostring GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_types.generated.typefromstring GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_types.generated.h GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_types.generated.c GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_methods.generated.h GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_methods.generated.c GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi_methods.generated.macro GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi.generated.h GEN /home/berrange/src/virt/libvirt/build/src/esx/esx_vi.generated.c Generating virthypervgen with a custom command GEN /home/berrange/src/virt/libvirt/build/src/hyperv/hyperv_wmi_classes.generated.typedef GEN /home/berrange/src/virt/libvirt/build/src/hyperv/hyperv_wmi_classes.generated.h GEN /home/berrange/src/virt/libvirt/build/src/hyperv/hyperv_wmi_classes.generated.c

And one problem I think is unrelated / pre-existing, but lost in the noise of automake: ../tests/qemuxml2xmltest.c: In function ‘mymain’: ../tests/qemuxml2xmltest.c:132:1: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 132 | mymain(void) | ^~~~~~

The conversion has introduced 9 new shell scripts in scripts/. IMHO, all of these need to be python scripts instead to follow out intent to standardize on python. I dream of a world with zero shell scripts.