Thanks for the reviews!

I'll get started on a V2 :) 

--Nico 

On Mon, Oct 5, 2020 at 5:32 AM Peter Krempa <pkrempa@redhat.com> wrote:
On Mon, Oct 05, 2020 at 11:11:54 +0200, David Hildenbrand wrote:
> On 05.10.20 10:06, Peter Krempa wrote:
> > On Fri, Oct 02, 2020 at 11:59:43 -0400, Nico Pache wrote:
> >> xml:
> >> <devices>
> >>   <memballoon model='virtio' free-page-reporting='on'/>
> >
> > according to what you state in the cover-letter this is a
> > 'virtio-balloon-pci' feature. We usually put stuff which depends on a
> > specific model of the device into the <driver> subelement of the device
> > element.
>
> IIRC, this should work for virtio-balloon-*, including virtio-balloon-ccw.

In that case the qemu capability detection should be added also for the
ccw version and capability name needs to be modified to not include pci.