Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum
On 08/24/2012 09:57 AM, Daniel Veillard wrote:
>> ACK, the only annoyance is that the name being longuer the
simple
>> substitution leads to lines over 80 characters, I would be a proponent
>> of dropping the indentation to the opening ( for the sake of keeping
>> everything on one 80 char line
>
> Should I go ahead and push the patch as-is, or go with one of
the
> shorter names? After all, long lines are a cosmetic issue, and I'd
> rather code with long names that are legible than short names that leave
> me scratching my head.
Oh, sure push :-)
Done.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)