Re: [libvirt] [PATCH] configure: Prefer /usr/bin over /bin for numad

On Wed, Nov 16, 2016 at 02:28:19PM +0100, Martin Kletzander wrote: AC_PATH_PROG looks like AC_PATH_PROG (variable, prog-to-check-for, [value-if-not-found], [path]) and iptables has AC_PATH_PROG([IPTABLES_PATH], [iptables], /sbin/iptables, [/usr/sbin:$PATH]) so the /sbin for iptables is used if it's not found. Since the lookup starts at /usr/sbin everything is fine here. But this block will fail entierely: dnl External programs that we can use if they are available. dnl We will hard-code paths to these programs unless we cannot dnl detect them, in which case we'll search for the program dnl along the $PATH at runtime and fail if it's not there. … since all the item below that have /sbin first. I missed that in my initial grep since it's wrapped on several lines. Looking further I found several tools that have $PATH first on the list like AC_PATH_PROG([MOUNT], [mount], [], [$PATH:/sbin:/usr/sbin]) while others have it at the end (like iptables above). I think adding $PATH first is preferable since distros (and users) can set that properly and it would solve the numad case too. This would also solve the numad case. I'll send a patch that does just that. Cheers, -- Guido