On Tue, Oct 29, 2013 at 02:12:00PM -0600, Eric Blake wrote:
[adding bug-gnulib]
On 10/29/2013 11:15 AM, Martin Kletzander wrote:
On Mon, Oct 28, 2013 at 03:50:20PM -0600, Eric Blake wrote:
Since we haven't quite frozen yet, it's time to pick up some fixes. I know at least cygwin benefits from this update.
* .gnulib: Update to latest, in part for cygwin compilation.
Even though that's not your fault, this might interest you:
root@freebsd9:/home/jenkins/workspace/libvirt/platform/freebsd-9/gnulib/tests # ./test-poll Unconnected socket test... passed Connected sockets test... failed (expecting POLLHUP after shutdown) General socket test with fork... failed (expecting POLLHUP after shutdown) Pipe test... passed
Has that test been failing prior to my submodule update for libvirt? This is likely a latent bug in gnulib that has been manifesting itself on FreeBSD for a much longer time period than just the month's worth of patches I pulled in by updating; but you are right that it would be nice to fix it upstream.
I thought it did fail earlier, but now I see it didn't. There was an IP addresses misconfiguration, but trying that now, I can only find a commit on which there were 2 errors instead of 3, but none which would successfully survive 'make check'. So sorry for the noise I made about that. Martin
And two other tests fail as well. I, however, couldn't find a time to look at that, so I'm just sending this to you in case you'd like to go deeper with it.
Martin
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org