On a Monday in 2020, Peter Krempa wrote:
The comment mentioned that the function resets migration params, but
that is not true.
Not true as of commit eb54cb473a8d140e0dd4a7bd42e8bcd72b056368
qemu: Reset all migration parameters
Also, you remove "free the secinfo" from the comment, even though it
still does free it.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_migration_params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 8c552ab9a0..f9bc43afee 100644
--- a/src/qemu/qemu_migration_params.c
+++ b/src/qemu/qemu_migration_params.c
@@ -1061,7 +1061,7 @@ qemuMigrationParamsDisableTLS(virDomainObjPtr vm,
* @apiFlags: API flags used to start the migration
*
* Deconstruct all the setup possibly done for TLS - delete the TLS and
- * security objects, free the secinfo, and reset the migration params to "".
+ * security objects.
*/
static void
qemuMigrationParamsResetTLS(virQEMUDriverPtr driver,
--
2.24.1
With the secinfo change mentioned in the commit message:
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano