Re: [libvirt PATCH 12/20] tests: depend on WITH_JSON_C instead of WITH_YAJL
On Wed, Aug 14, 2024 at 23:40:27 +0200, Ján Tomko wrote:
After the series finale, there will be no WITH_YAJL anymore.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
tests/meson.build | 6 +++---
tests/virnetdaemontest.c | 2 +-
tests/virstoragetest.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/meson.build b/tests/meson.build
index d1fc122fc7..d6e73bfba0 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -330,7 +330,7 @@ if host_machine.system() == 'linux'
{ 'name': 'virscsitest' },
{ 'name': 'virusbtest' },
]
- if conf.has('WITH_YAJL')
+ if conf.has('WITH_JSON_C')
Shouldn't we introduce "WITH_JSON" and use that across these checks? The
specific library-dependant defines can be then used where it actually
matters.
The above may be useful also in other cases such as if you'll want to
fix the rollover to the new library in the '*nss*' files which do not
get an interim implementation with both YAJL and json-c.