Re: [PATCH] tools: only fail validations if VIR_HOST_VALIDATE_FAIL is set

6 Jun 2021


      [...]
...
@@ -464,12 +514,15 @@ int virHostValidateSecureGuests(const char *hvname,
             if (!virFileIsDir("/sys/firmware/uv")) {
                 virHostMsgFail(level, "IBM Secure Execution not supported by "
                                       "the currently used kernel");
-                return 0;
+                goto out;
             }
-            if (virFileReadValueString(&cmdline, "/proc/cmdline") < 0)
-                return -1;
-
+            if (virFileReadValueString(&cmdline, "/proc/cmdline") < 0) {
+                if (level == VIR_HOST_VALIDATE_FAIL) {
+                    ret =  -1;
+                    goto out;
Oops, this `goto out;` should be out of the if scope, sorry.
I'll fix this and re-submit a v2 after I get some reviews on this version.

[...]

Best Regards,
-- 
Fabiano Fidêncio

    