Re: [PATCH v2 1/1] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release
On 5/9/22 07:00, Andrea Bolognani wrote:
On Fri, May 06, 2022 at 04:54:22PM -0300, Daniel Henrique Barboza
wrote:
> No relevant changes since the last update from 7.0.0-rc2. Sending it so
> we're sure that we don't need to worry about ppc64 caps for the 7.0.0
> release anymore.
There are actually a few additional features available in this build:
<flag name='memory-backend-file.pmem'/>
<flag name='virtio-gpu-gl-pci'/>
<flag name='virtio-vga-gl'/>
Not sure how much of that is because of build configuration rather
than changes in QEMU. Probably all of it :)
I'd say that these are all build configuration related. I would be surprised
if people added 7.0.0 capabilities after 7.0.0-rc2.
Regardless, considering the above I would say that the commit message
is not accurate. Would you be okay with something like
There are no major changes since 7.0.0-rc2, but a few additional
features are enabled in this build.
? If so, I can amend the commit message and push the patch as
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Yes please, go ahead. Thanks!
As a side note, it's unfortunate that this sort of small change gets
lost in the noise when updating capabilities. I wonder if anything
can be done about it.
We can add a documentation about the host build configuration (i.e. packages installed
and QEMU build options) that were used in the recent/last qemucapabilities update. That
way one can try to replicate a similar build configuration setup and avoid these build
differences.
E.g: from the previous version that was missing a lot of stuff versus this one I've
installed the following packages in a Power9 running Fedora35:
dnf install libusb-devel libcap-ng-devel libssh-devel libpmem-devel \
libiscsi-devel libnfs-devel libseccomp-devel libseccomp-static \
liburing-devel libbpf-devel librbd-devel \
libcurl-devel libaio-devel \
egl-utils egl-wayland-devel \
virglrenderer-devel \
gtk+-devel spice-gtk3-devel \
fuse3-devel gtkglext-devel \
lzo-devel brlapi-devel snappy-devel
Aside from that, in the end it's hard to distinguish between "this feature
isn't
present in ppc64" versus "the host that generated the capabilities didn't
have the
support installed" because it's the same thing from the qemucaps standpoint.