Re: [libvirt] [PATCH v3] storage: Sanitize pool target paths

On 05/24/2010 12:52 PM, Cole Robinson wrote:

+ + /* Need to sanitize: + * // -> // + * /// -> / + * /../foo -> /../foo + * /.//foo -> /foo + * /foo///bar/ -> /foo/bar + * ./foo/./. -> /foo + */ +

For my second attempt at a valid review, I actually compiled the function, and threw the above inputs at it. /../foo -> /./foo (oops, didn't match documentation), and ./foo/./. -> /foo (oops, matched documentation, but turned a relative path into absolute), so we do need a v4, but not for the original reasons in my first NAK where I mis-read the do-while loop. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org