Thanks Jiri,

I am grateful for that quick feedback and your proposal to do further changes,

Here is my Sign-off line:

    Signed-off-by: Hector Cao <hector.cao@canonical.com>

Best regards
Hector

On Tue, Nov 25, 2025 at 11:59 AM Jiri Denemark <jdenemar@redhat.com> wrote:
On Mon, Nov 24, 2025 at 14:40:28 +0100, Hector Cao wrote:
> Currently, libvirt is unable to detect the CPU
> model of recent Intel CPUs (like Granite Rapids)
> with VMX-* features specified in the MSRs (Model Specific
> Registers). This is due to the wrong parsing of these
> VMX-* features from the MSR values.
>
> This series of 3 commits allow to fix the MSR VMX-*
> feature detection.
>
> This has been tested successfully on a platform equipped
> with Intel Granite Rapids CPU.
>
> Hector Cao (3):
>   cpu_map: fix sync script to extract correctly vmx-* features
>   cpu_map: update vmx-* features
>   cputest : fix test failures due to VMX-* feature update
>
>  src/cpu_map/sync_qemu_features_i386.py        |  19 +++
>  src/cpu_map/x86_features.xml                  | 136 +++++++++---------
>  .../x86_64-cpuid-Atom-P5362-2-enabled.xml     |  10 +-
>  .../x86_64-cpuid-Atom-P5362-enabled.xml       |  10 +-
>  .../x86_64-cpuid-Cooperlake-enabled.xml       |  10 +-
>  .../x86_64-cpuid-Core-i7-1270P-enabled.xml    |  10 +-
>  .../x86_64-cpuid-Core-i7-1365U-enabled.xml    |  10 +-
>  .../x86_64-cpuid-Core-i7-8550U-enabled.xml    |  10 +-
>  .../x86_64-cpuid-Xeon-6731E-enabled.xml       |  10 +-
>  .../x86_64-cpuid-Xeon-6788P-disabled.xml      |   1 +
>  .../x86_64-cpuid-Xeon-6788P-enabled.xml       |  10 +-
>  .../x86_64-cpuid-Xeon-6788P-guest.xml         |  17 ++-
>  .../x86_64-cpuid-Xeon-6788P-host.xml          |  17 ++-
>  ...x86_64-cpuid-Xeon-Bronze-3408U-enabled.xml |  10 +-
>  .../x86_64-cpuid-Xeon-E3-1270-v5-enabled.xml  |  10 +-
>  .../x86_64-cpuid-Xeon-Gold-6152-enabled.xml   |  10 +-
>  .../x86_64-cpuid-Xeon-Gold-6530-enabled.xml   |  10 +-
>  ...86_64-cpuid-Xeon-Platinum-9242-enabled.xml |  10 +-
>  ...x86_64-cpuid-Xeon-Silver-4214R-enabled.xml |  10 +-
>  .../x86_64-cpuid-Xeon-w7-3465X-enabled.xml    |  10 +-
>  20 files changed, 181 insertions(+), 159 deletions(-)

I wanted to fix the empty lines in the first patch, squash patches 2 and
3 into a single one so that I can push the series, but the patches are
missing Signed-off-by tags (see
https://libvirt.org/hacking.html#developer-certificate-of-origin)

You can either do the appropriate changes, add Signed-off-by and
resubmit or just reply with your Signed-off-by here and I'll add that to
the commits myself before pushing.

Thanks
Jirka



--
Hector CAO
Software Engineer – Server Team / Virtualization
hector.cao@canonical.com
https://launchpad.net/~hectorcao