Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

[David and Drew added to CC, feel free to skip to the bottom] On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: [...] > +            } else if (def->os.arch == VIR_ARCH_AARCH64 && > +                       virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI)) { > +                /* If possible use qemu-xhci as default controller for > +                 * aarch64, it's USB3 controller and we want to avoid using > +                 * nec-usb-xhci. */ > +                cont->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_QEMU_XHCI; If qemu-xhci is not available but usb-nec-xhci is, it would probably be nicer to pick the latter rather than leaving it unspecified (which will result in an error later on).

So I would basically use the same code as ppc64 here, minus the pci-ohci part of course.