
Thanks! I assume the tests were added as well apart from the patch?
-----Original Message----- From: Daniel Veillard [mailto:veillard@redhat.com] Sent: Thursday, December 11, 2008 13:45 PM To: Itamar Heim Cc: Libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)
On Wed, Dec 10, 2008 at 06:06:51AM -0500, Itamar Heim wrote:
Sure - probably not a good idea to send patches at such a late hour anyway :) Attached diff.
Some more details: For those using SDL ("for some crazy reason" as Berrange put it in the original patch), there is a use for the fullscreen option, causing the qemu window to open in full screen, change resolution, etc. This patch accepts an additional attribute in the graphics element: <graphics type='sdl' display=':0.1' xauth='/root/.Xauthority' fullscreen='true'/>
If fullscreen is true, "-full-screen" is added to the qemu command line (unlike the display and auth which are added as environment variables)
Okay, to avoid having this patch forgotten in a nitpicking discussion (I'm guilty I started :-) I commited the following which integrate the associated changes and keep the final code in line with the existing one: - make the check at parse time - use an int to store the data - use yes/no as the accepted values - error out if the attribute value does not follow - drop all bool usage - fix docs/libvirt.rng to detail the new optional attribute and its 2 values - fix docs/formatdomain.html[.in] to describe the attributes for the sdl display type. - fix the test to use the new value 'yes' in the xml
I guess this covers most of the changes needed for this patch, now you can blame me if I forgot something :-) but this passes the tests (well there is errors on the uml tests I didn't figured out yet but looks unrelated.
thanks Itamar !
Daniel
-- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/