Re: [libvirt] [PATCH v4 03/11] nvdimm: introduce 'unarmed' element into xml for NVDIMM memory

18 Dec 2018


      On 2018/12/17 下午7:07, Daniel P. Berrangé wrote:
...
On Mon, Dec 17, 2018 at 05:26:13PM +0800, Luyao Zhong wrote:
...
The 'unarmed' option allows users to mark vNVDIMM read-only:
Why don't we call this element <readonly/>  then ?
Just keep the same with QEMU, hah~ :)
...
...
<devices>
   ...
   <memory model='nvdimm' access='shared'>
       <source>
           <path>/dev/dax0.0</path>
       </source>
       <target>
           <size unit='MiB'>4094</size>
           <node>0</node>
           <label>
               <size unit='MiB'>2</size>
           </label>
           <unarmed/>
       </target>
   </memory>
   ...
</devices>
Regards,
Daniel
Thanks,
Luyao