Re: [libvirt PATCH 5/6] qemu: probe for "acpi-index" property
On Tue, Apr 06, 2021 at 08:27:07PM +0200, Igor Mammedov wrote:
On Tue, 6 Apr 2021 16:31:36 +0100
Daniel P. Berrangé <berrange(a)redhat.com> wrote:
> This property is exposed by QEMU on any PCI device, but we have to pick
> some specific device(s) to probe it against. We expect that at least one
> of the virtio devices will be present, so probe against them.
Would it be useful to expose capability with MachineInfo in QAPI schema?
I dont think it really belongs with MachineInfo, as it is a device
property. The issue is really that QEMU has a class hierarchy, but
the QMP device info flattens this, to avoid exposing the existance
of the class hierarchy for devices.
At least with this on QEMU side I can imagine a crude check and error
out
in case device has acpi-index set but machine doesn't support it.
Any improved error checking in QEMU is welcome if i detects configs
that cannot possibly work due to missing support, as libvirt doesn't
really want to check every possible scenario itself.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|