On Mon, May 20, 2013 at 11:40:34AM -0600, Jim Fehlig wrote:
I finally have some time to continue reviewing this series...
Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Introduce use of a virDomainDefPtr in the domain migrate & start APIs to simplify introduction of ACL security checks.
Not really the 'start' API, but GetXMLDesc, Define, and Undefine. Should those be part of the lifecycle changes made in patch 2?
Opps bad description. I tried to make each patch as small as possible. So where I grouped several methods together, I only did it because they were mutually dependent wrt the refactoring. Will fix the description of this commit.
@@ -44,7 +44,8 @@ int xenXMDomainGetState(virConnectPtr conn, virDomainDefPtr def, int *state, int *reason); -char *xenXMDomainGetXMLDesc(virDomainPtr domain, unsigned int flags); +virDomainDefPtr xenXMDomainGetXMLDesc(virConnectPtr conn, + virDomainDefPtr def);
This still squeezes into one line too.
As you've probably seen by now, I've preferred to split the lines when there are > 1 parameter in the method, even if it would technically fit on one line. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|