On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau <cfergeau@redhat.com> wrote:
+ + +const char *gvir_config_domain_snapshot_disk_get_driver_type(GVirConfigDomainSnapshotDisk *disk)
Shouldn't 'driver_type' be an enum?
libvirt is storing it internally as a string, see http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/conf/snapshot_conf.c;h=5b... libvirt-gconfig generally follows what libvirt does when it comes to choosing between strings and enums. This is also consistent with gvir_config_domain_disk_set_driver_type(). However, the rng defines http://libvirt.org/git/?p=libvirt.git;a=blob;f=docs/schemas/domaincommon.rng... for this attribute. Daniel, any recommendation? Christophe