Re: [Libvir] [PATCH] Another Report error in virsh.c code.
On Tue, Mar 11, 2008 at 05:09:45PM +0900, S.Sakamoto wrote:
BTW, I think another message is needed here to inform the internal
error to user.
For example, the migrate command shows the following message when
"desturi" is missing:
migrate: Missing desturi
But it does not show the error-message even though "migrateuri"
is missing because "migrateuri" is *not* a necessary option.
I'm not sure I follow what is wrong. 'desturi' is required, so if
missing we get an error. 'migrateuri' is not required, so there is no
error if it is missing. And that's what the code does.
So, I want to unify "virsh.c" with the following rules,
- for necessary option
show the message if error occur
- for unnecessary option
do not show the message even if error occur
Do you have a patch or another way to explain this, because I'm afraid
I don't follow what you mean.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top