Re: [libvirt] [RFC PATCH 0/9] qemu: add vhost-vsock-pci support
On Tue, May 22, 2018 at 11:40:25AM +0200, Ján Tomko wrote:
On Mon, May 21, 2018 at 04:46:13PM +0100, Daniel P. Berrangé wrote:
> On Mon, May 21, 2018 at 05:37:10PM +0200, Ján Tomko wrote:
> > @Stefan, please take a look at the docs/ changes in patch 6
> >
> > Add <interface type='vsock'>, mapping to vhost-vsock-pci
>
> I think it is pretty misleading to use <interface> for this, because
> the whole point of vsock existing is that it is *not* a NIC !
>
> I think we need to use a new type of element for this, because none
> of the existing ones are relevant.
>
Right, how does <vsock> sound?
Sure, fine.
Also, I probably mixed up the target and source here - the guest_cid
should be in <source>, since that's where the host will see it.
The <target cid> is 2 by definition.
We are a bit inconsistent but '<source>' typically refers to some
resource in the host, which would mean <target> refers to the guest.
The fun bit is with <interface> both <source> and <target> refer
to things in the host :-)
We could just set the cid as an attribute on <vsock> though, or just
call it <cid>55</cid>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|