Re: [libvirt] [PATCH 2/6] qemu: Plug memory leak on qemuProcessWaitForMonitor() error path

At 11/30/2011 01:57 PM, ajia@redhat.com Write:

From: Alex Jia <ajia@redhat.com>

Detected by Coverity. Leak introduced in commit 109efd7.

Signed-off-by: Alex Jia <ajia@redhat.com> --- src/qemu/qemu_process.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2563f97..f3f44ca 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1224,6 +1224,7 @@ qemuProcessWaitForMonitor(struct qemud_driver* driver,

if (VIR_ALLOC_N(buf, buf_size) < 0) { virReportOOMError(); + VIR_FORCE_CLOSE(logfd); return -1;

I think it is better to goto closelog Thanks Wen Congyang

}