On Thu, Nov 27, 2008 at 01:30:07PM +0100, Daniel Veillard wrote:
On Thu, Nov 27, 2008 at 12:20:26PM +0000, Daniel P. Berrange wrote:
It is possible for disks to be listed without a source file against them, eg a CDROM device with no media loaded. The XenD driver handles this, but the XM driver incorrectly generates XML with a <source file=''/> element instead of omitting the element entirely. This causes a bogus SXEXPR to be sent to XenD when starting the domain. This patch does three things
- Makes the generic domain_conf.c XML parser accept XML docs with a bogus <source file=''/> and convert the source to NULL, instead of passing along the empty string "". This protects against broken apps
- Makes the XM driver correctly generate XML in the first place, so omitting the <source> tag entirely. This is the root cause fix
- Adds a test case for the XM driver to validate handling of devices with a source file
sounds and looks fine by me,
Thanks, committed this fix. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|