Re: [libvirt] [PATCH] fix MinGW compilation(200808)
On Mon, Aug 11, 2008 at 07:57:46PM +0900, Atsushi SAKAI wrote:
Hi, Jim and Dan
Thank you for commenting.
I compiled with attached patch successfully.
This is bit not good:
diff -u -r1.6 domain_conf.h
--- src/domain_conf.h 8 Aug 2008 15:03:00 -0000 1.6
+++ src/domain_conf.h 11 Aug 2008 10:53:21 -0000
@@ -444,9 +444,11 @@
typedef struct _virDomainObj virDomainObj;
typedef virDomainObj *virDomainObjPtr;
struct _virDomainObj {
+#ifdef WITH_QEMU
int stdin;
int stdout;
int stderr;
+#endif
int monitor;
int logfile;
int pid;
The domain_conf.{c,h} is *generic* code and should have no driver-specific
bits in it. As such there's no need for WITH_QEMU conditional compilation
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|