Re: [Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror
Hi Rich,
Good stuff, looks fine to commit to me.
Just a nitpick:
On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
- activeNames = vshMalloc(ctl, sizeof(int) * maxactive);
+ activeNames = vshMalloc(ctl, sizeof (char *) * maxactive);
^
- qsort(&activeNames[0], maxactive, sizeof(int),
namesorter);
+ qsort(activeNames, maxactive, sizeof (char *), namesorter);
^
Extra whitespace here ...
Cheers,
Mark.