Re: [libvirt] [PATCH v2 10/10] nodeinfo: Calculate present and online CPUs only once

> - present_cpumap = nodeGetPresentCPUBitmap(sysfs_prefix); > - if (!present_cpumap) > - goto cleanup; > - online_cpus_map = nodeGetOnlineCPUBitmap(sysfs_prefix); > - if (!online_cpus_map) > - goto cleanup; > - > - npresent_cpus = virBitmapSize(present_cpumap); This still can be extracted here since the caller doesn't care about the npreset count so you are basically passing redundant info. ACK to the rest. I'll revert this part and adjust the patch accordingly before pushing.