Re: [libvirt] [PATCH v2 2/2] qemu: report an error if memballoon has wrong address type

On 04/30/2013 12:14 AM, Eric Blake wrote:

On 04/29/2013 12:20 PM, Ján Tomko wrote:

...

qemuBuildMemballoonDevStr returns NULL if memballoon doesn't have the right address type, but it doesn't report an error, leading to: error: An error occurred, but the cause is unknown

Report a helpful error message instead, e.g.: error: XML error: memballoon unsupported with address type 'usb' --- src/qemu/qemu_command.c | 3 +++ 1 file changed, 3 insertions(+)

ACK. Both worth including in 1.0.5

Thanks, both pushed now. Jan