Re: [libvirt] [PATCH] Determine kvm max vcpus via version number

Daniel Veillard wrote: > On Fri, Sep 05, 2008 at 12:25:16PM -0400, Cole Robinson wrote: >> The attached patch is a slimmed down version of a patch >> I posted a while back. This expands qemu help message >> parsing to look for a kvm version number, which can be >> used to determine maximum supported vcpus. >> >> A kvmVersion field is added to the qemu_driver structure, >> and a check to determine the version is added to the >> libvirtd start up routine. If the kvm version isn't found >> (say if kvm isn't installed), kvmVersion is set to 0. >> >> This is against Guido Gunther's patch "maxVCPU runtime >> detection": his method takes precendence in the code >> if it's available. > > Looks fine to me, > > Daniel > I'm actually taking this off the table. I think Guido's solution is sufficient: works fine on f8, where as mine would have to accomodate different qemu help messages between at least f8 and f9, which is just getting into more work and complexity. So please ignore this patch.