Re: [libvirt] [PATCH v3 08/10] Turn virSocket into a virObject
On 08/06/2012 05:53 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
Make virSocket use the virObject APIs for reference counting
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
src/libvirt_private.syms | 1 -
src/libvirt_probes.d | 4 +--
src/qemu/qemu_migration.c | 4 +--
src/rpc/virnetclient.c | 4 +--
src/rpc/virnetserverclient.c | 4 +--
src/rpc/virnetserverservice.c | 4 +--
src/rpc/virnetsocket.c | 71 ++++++++++++++++++-----------------------
src/rpc/virnetsocket.h | 3 +-
tests/virnetsockettest.c | 26 +++++++--------
9 files changed, 54 insertions(+), 67 deletions(-)
Missing two changes. ACK with this squashed in:
diff --git i/cfg.mk w/cfg.mk
index dc39646..535d67b 100644
--- i/cfg.mk
+++ w/cfg.mk
@@ -155,7 +155,6 @@ useless_free_options = \
--name=virNetServerMDNSGroupFree \
--name=virNetServerProgramFree \
--name=virNetServerServiceFree \
- --name=virNetSocketFree \
--name=virNWFilterDefFree \
--name=virNWFilterEntryFree \
--name=virNWFilterHashTableFree \
diff --git i/src/libvirt_private.syms w/src/libvirt_private.syms
index 5a58f3f..5ee4eba 100644
--- i/src/libvirt_private.syms
+++ w/src/libvirt_private.syms
@@ -1596,7 +1596,6 @@ virNetSocketNewListenTCP;
virNetSocketNewListenUNIX;
virNetSocketRead;
virNetSocketRecvFD;
-virNetSocketRef;
virNetSocketRemoteAddrString;
virNetSocketRemoveIOCallback;
virNetSocketSendFD;
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)