Eric Blake <eblake@redhat.com> wrote on 03/18/2010 03:29:17 PM:

> On 03/18/2010 09:18 AM, Stefan Berger wrote:
> > This patch adds support for L3/L4 filtering using iptables. This adds
> > support for 'tcp', 'udp', 'icmp', 'igmp', 'sctp' etc. filtering.
> >
> > As mentioned in the introduction, a .c file provided by this patch
> > is #include'd into a .c file. This will need work, but should be alright
> > for review.
> >
> > Signed-off-by: Stefan Berger <stefanb@us.ibm.com>
>
> [same caveats as earlier in this thread...]
>
> > +                      unsigned int priority,
> > +                      int isIptablesRule)
> >  {
> >      ebiptablesRuleInstPtr inst;
> >  
> > @@ -225,6 +229,7 @@ ebiptablesAddRuleInst(virConnectPtr conn
> >      inst->neededProtocolChain = neededChain;
> >      inst->chainprefix = chainprefix;
> >      inst->priority = priority;
> > +    inst->isIptablesRule = isIptablesRule;
>
> This should be bool, not int.

Changed this now.

Thanks and regards,
   Stefan


>
> --
> Eric Blake   eblake@redhat.com    +1-801-349-2682
> Libvirt virtualization library http://libvirt.org
>
> [attachment "signature.asc" deleted by Stefan Berger/Watson/IBM]