Re: [libvirt PATCH v2 02/16] qemu: Add qemuNbdkitCaps to qemu driver
On Wed, Sep 28, 2022 at 10:51:12 -0500, Jonathon Jongsma wrote:
On 9/19/22 9:09 AM, Peter Krempa wrote:
> > +{
> > + qemuNbdkitCaps *nbdkit = QEMU_NBDKIT_CAPS(object);
> > +
> > + g_clear_pointer(&nbdkit->path, g_free);
> > + g_clear_pointer(&nbdkit->version, g_free);
> > + g_clear_pointer(&nbdkit->flags, virBitmapFree);
> > +
> > + G_OBJECT_CLASS(qemu_nbdkit_caps_parent_class)->finalize(object);
> > +}
> > +
> > +
> > +void qemu_nbdkit_caps_init(qemuNbdkitCaps *caps)
>
> Same here and also inconsistent capitalization format.
regarding the capitalization format, this is the implementation of a
function that is declared by G_DEFINE_TYPE, so it needs to be formatted this
way.
Ah, right. I forgot about that.
> > +
> > +typedef struct _qemuNbdkitCaps qemuNbdkitCaps;
> > +
> > +typedef enum {
>
> You should go for the same markers you have when implementing the enum.
I'm afraid I can't quite figure out what you're trying to suggest here.
Yeah, I had to look back too to try to figure out what I meant :D.
In the .c file where you define the conversion functions via the
VIR_ENUM_IMPL macro you've used grouping separators (/* 0 */) similarly
to what we do for the qemu capabilities, but not in the header. So they
should be used in both places.