Re: [libvirt] [PATCHv7 11/18] conf: move virResctrlAllocIsEmpty to a place a litter lower

On 2018年11月06日 01:26, John Ferlan wrote:

$SUBJ:

s/litter/little

Perhaps better said:

conf: Alter order of Cachetune virDomainResctrlNew call

...

This refactor allows to add some code between virDomainResctrlNew and virResctrlAllocIsEmpty to extend the scope of resctrl.

On 10/22/18 4:01 AM, Wang Huaqiang wrote: this then becomes:

Refactor the logic to handle subsequent generation of a resource monitor which would effect whether a non default cache exists.

Thanks for wording.

...

Signed-off-by: Wang Huaqiang <huaqiang.wang@intel.com> --- src/conf/domain_conf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

Thanks for your review. Huaqiang