Re: [Libvir] gnulib: take2, trunk-relative patch
Jim Meyering wrote:
"Richard W.M. Jones" <rjones(a)redhat.com> wrote:
> Jim, I also needed the attached patch, and then I had to do this:
>
> cd docs/examples && ./index.py
...
> -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
> +LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la \\
> + $(top_builddir)/gnulib/lib/libgnu.la
Hi Rich,
I don't seem to need it. I.e., ./index.py works fine without it:
$ ./index.py
loading ../libvirt-api.xml
Parsing info1.c
Parsing suspend.c
If you could give me details of why you needed it,
I'd feel better about applying it.
Hi Jim,
It's not index.py that fails, but the Makefile.am (which in that
directory is generated). More specifically, a program called 'info1'
fails to link:
gcc -g -O2 -o .libs/info1 info1.o -Wall -Wformat -Wformat-security
-Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow
-Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes
-Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fasynchronous-unwind-tables -Werror
../../src/.libs/libvirt.so -lxml2 -lgnutls -lxenstore
../../src/.libs/libvirt.so: undefined reference to `physmem_total'
collect2: ld returned 1 exit status
make[4]: *** [info1] Error 1
make[4]: Leaving directory `/home/rjones/d/libvirt-mingw/docs/examples'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/rjones/d/libvirt-mingw/docs/examples'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/rjones/d/libvirt-mingw/docs'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/rjones/d/libvirt-mingw'
make: *** [all] Error 2
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
Attachments:
- smime.p7s (application/x-pkcs7-signature — 3.2 KB)