Re: Libvirt Open Source Contribution
Michal,
We've struggled with the email system so far. You may have seen when we
submitted a chain of 65 patches when we meant to send only the last commit.
We tested this by sending it to ourselves first but must have made a
mistake when submitting to libvir-list.
We submitted an initial patch for issue-11, which was rejected because Ryan
emailed the patch, but I was CCed. I am working on getting my computer set
up to submit this patch myself.
Additionally, we submitted a patch for issue-16 (from Ryan Gahagan), and we
feel confident we did this correctly (even received a confirmation email).
However, we have not seen the patch posted on the forum nor have we
received any email that the patch was rejected. Is it possible it has not
been posted because we left outstanding questions in the patch?
Best regards,
Barrett Schonefeld
On Fri, Nov 6, 2020 at 2:03 AM Michal Prívozník <mprivozn(a)redhat.com> wrote:
On 11/5/20 10:04 PM, Barrett J Schonefeld wrote:
> Hey folks,
>
> We appreciate the feedback, and we've used this to complete some initial
> work on issue 11.
>
> We started with small changes in src/util, and we submitted them via
> email (following these guidelines on submitting patches
> <https://libvirt.org/submitting-patches.html>) to ensure we are on the
> right path.
>
> We do not see the patch we submitted via email showing up in the
> threads, and we are wondering if we are submitting incorrectly or if the
> patch goes through some approval process before appearing in the threads.
>
> Best regards,
> Barrett Schonefeld
So I checked the moderator's queue and there are no patches stuck, so
probably it is something else. Did you see any error when 'git
send-email'-ing the patches? When I was setting up my machine I used to
send patches just to me to verify send-email is working and only then I
tried to send patches to the list.
Also, are you sure you (the sender) are subscribed to the list?
Generally, if you aren't then list won't forward your e-mails/patches.
Michal
Attachments:
- attachment.html (text/html — 3.4 KB)