On Mon, Nov 30, 2009 at 10:17:55PM +0100, Soren Hansen wrote:
On Mon, Nov 30, 2009 at 10:26:12AM +0000, Daniel P. Berrange wrote:
I've changed the libvirt package in Ubuntu to run the test suite with every build. However, on our build daemons, the eventtest unit test seems to almost[1] consistently fail. You can see an example build log here:
http://launchpadlibrarian.net/36196282/buildlog_ubuntu-lucid-amd64.libvirt_0...
Does this look familiar to anyone? Any idea what might be causing this? FWIW, I cannot reproduce it locally, so it's likely environmental, but at this point, I don't really know where to begin to look. What HZ setting are the kernels on the problem host running with ? IIRC we had someone else report a problem with this test suite on a kernel built with HZ=100, rather than the more common HZ=1000
Ah, indeed they are running with HZ=100.
So this is a known problem? Is there a known fix?
Can you see if this makes any difference diff --git a/daemon/event.c b/daemon/event.c index 10847c4..ed11e78 100644 --- a/daemon/event.c +++ b/daemon/event.c @@ -413,7 +413,7 @@ static int virEventDispatchTimeouts(void) { if (eventLoop.timeouts[i].deleted || eventLoop.timeouts[i].frequency < 0) continue; - if (eventLoop.timeouts[i].expiresAt <= now) { + if (eventLoop.timeouts[i].expiresAt <= (now+20)) { virEventTimeoutCallback cb = eventLoop.timeouts[i].cb; int timer = eventLoop.timeouts[i].timer; void *opaque = eventLoop.timeouts[i].opaque; Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|