On 06/20/2016 11:28 AM, Ján Tomko wrote:
Introduced by commit d575679, unused at the time. --- src/util/virnetlink.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 5491ece..513f36e 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -42,10 +42,6 @@ #include "virmacaddr.h" #include "virerror.h"
-#ifndef SOL_NETLINK -# define SOL_NETLINK 270 -#endif - #define VIR_FROM_THIS VIR_FROM_NET
VIR_LOG_INIT("util.netlink");
Provisional ACK since you are correct that it isn't visibly used, but I can't help thinking the author had some reason for adding it. It looks like SOL_NETLINK wasn't present in kernel 2.6 (RHEL6 vintage - although it is mentioned in a comment of one of the system #includes), but was there by the time of kernel 3.10 (RHEL7). I Cc'ed the author's email on this reply. If we don't hear back from him, I guess we can assume it was something put in to test an alternate netlink protocol, and we can add it back in later if it causes a build problem on some platform, or is needed for something in the future. (I did try a stock build on RHEL6 with this chunk removed, and it had no problems; that, combined with the fact that it's defined below all the #includes in the file shows that it's not a case of a reference hidden in an include file somewhere).