Re: [libvirt] [PATCH 07/10] qemu: blockjob: Don't stop processing the finished job early

On 11/26/19 10:17 AM, Peter Krempa wrote:

Both failure to refresh and to dismiss the job are very unlikely but if they happen there's not much we can do about the blockjob.

The concluded job handlers treat it as if the job failed if we don't update the state to 'QEMU_BLOCKJOB_STATE_COMPLETED' which is probably the safest thing to do here.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/qemu/qemu_blockjob.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-)

Reviewed-by: Cole Robinson <crobinso@redhat.com> - Cole