Re: [libvirt] [PATCH v2] Fix dnsmasq/radvd on bridges not being able to be bound to IPv6 address on "recent" kernels
On 06/20/2012 05:49 AM, Benjamin Cama wrote:
Le mercredi 20 juin 2012 à 11:05 +0100, Daniel P. Berrange a écrit :
> I think you also need to have a VIR_FOFRCE_CLOSE(tapfd) in the
> very last of the cleanup jump labels. Since between the time
> we open the tapfd & close it, we might have done a 'goto err1'
> or similar.
Yes, I forgot that. New patch following.
> Looks reasonable apart from the cleanup bug.
Thanks. BTW, if this patch is commited, I'm already in AUTHORS under
another email address, which is OK.
If you have two git commits under different email addresses, then we
should update .mailmap to set up the aliases so that your preferred
address in AUTHORS is attributed to all your other commits on any other
address. Otherwise, 'make syntax-check' complains about a mismatch
between commit authorship.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)