On 07/31/2013 06:59 AM, Peter Krempa wrote:
For that matter, 'make check' for day-to-day usage should be able to skip the gnulib subdirectory - the results in gnulib/tests will only change if you upgrade the gnulib submodule, glibc, or some other core component, which is not what we change on a day-to-day basis when hacking gnulib, but is also something an autobuilder should be running always. I'll see if I can hack something up to speed up 'make check' for normal users on the gnulib front, which we can then extend into skipping Peter's new test.
Good idea to skip gnulib tests.
GNU coreutils calls its variable RUN_EXPENSIVE_TESTS, defaulting to no, but set to yes in autobuilders. Sounds like the best type of naming (maybe VIR_TEST_EXPENSIVE, to keep it in the VIR_ namespace). Anyone else want to chime in with a bikeshed color?
That sounds like a fine name to me.
I like it too.
v1 patch proposed: https://www.redhat.com/archives/libvir-list/2013-July/msg01986.html For the sake of Peter's test, I think that a getenv("VIR_TEST_EXPENSIVE") in the C code will be easier to implement than Makefile hackery, except that my patch didn't hack the makefile to guarantee that VIR_TEST_EXPENSIVE will be in TESTS_ENVIRONMENT if configure requested enabling tests. (Hmm, this alone makes me think I should make the configure option and environment variable name match, rather than having --enable-gnulib-tests vs. VIR_TEST_EXPENSIVE, so maybe I need a v2 after all) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org