Re: [libvirt] [PATCHv2] virBitmap: Place virBitmapIsAllClear check after virBitmapParse calls

On Mon, Apr 13, 2015 at 14:01:27 +0200, Erik Skultety wrote: > This patch adds checks for empty bitmaps right after the calls of > virBitmapParse. These only include spots where set API's are called and > where domain's XML is parsed. > Also, it partially reverts commit 983f5a which added a check for > invalid nodeset "0,^0" into virBitmapParse function. This change broke > the logic, as an empty bitmap should not cause an error. > > https://bugzilla.redhat.com/show_bug.cgi?id=1210545 > --- > src/conf/domain_conf.c | 35 +++++++++++++++++++++++++++++++---- > src/conf/numa_conf.c | 23 +++++++++++++++++++---- > src/qemu/qemu_driver.c | 5 +++-- > src/util/virbitmap.c | 3 --- > src/xenconfig/xen_sxpr.c | 7 +++++++ > tests/virbitmaptest.c | 13 ++++++++++--- > 6 files changed, 70 insertions(+), 16 deletions(-) ACK, thanks for adding the test. Peter