Re: [libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule
On Fri, 2017-04-07 at 16:56 +0100, Daniel P. Berrange wrote:
> I'm also wondering whether we can avoid having all
developers
> run 'git submodule init && git submodule update' after these
> changes have been pushed...
I assumed our blackmagic that deals with gnulib changing would
also pick up this addition and so make it 'just work', but
admittedly i've not tested that.
It doesn't, but I'm adding some more black magic and it
will once I'm done ;)
Just hold on a bit longer.
> > +util/virkeynametable_%.h:
$(srcdir)/keycodemapdb/data/keymaps.csv \
> > + $(srcdir)/keycodemapdb/tools/keymap-gen Makefile.am
> > + $(AM_V_GEN)export NAME=`echo $@ | sed -e 's,util/virkeynametable_,,'
\
> > + -e 's,\.h,,'` && \
> > + $(MKDIR_P) util/ && \
> > + $(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \
> > + --lang stdc --varname virKeyNameTable_$$NAME name-table \
> > + $(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \
> > + $@-tmp && mv $@-tmp $@ || rm $@-tmp
>
> Do you really need the dependency on Makefile.am there?
Well it ensures we rebuild files if we change these rules for some reason.
Right, makes sense. We should probably add the same
dependency to all other man pages and more generated files
as well, at least the former are missing it.
--
Andrea Bolognani / Red Hat / Virtualization