Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest
On Fri, Nov 03, 2023 at 12:00:30AM -0400, Laine Stump wrote:
[*] There may be a better way to suppress this environment setting
(maybe something done to prevent it from ever being added to the
environment in the first place?), and that would be fine too. This
patch does work though.
Yeah, I think this is pretty safe but it's kinda weird that this
specific environment variable would make it through despite our
filtering mechanisms in virCommand. So if some good soul with access
to a macOS 14 installation (*cough cough* ;) could try to figure out
why this started showing up all of a sudden, when it was not there
for any previous version of macOS, that would be absolutely awesome.
+++ b/tests/commandhelper.c
@@ -169,9 +169,12 @@ static int printEnvironment(FILE *log)
for (i = 0; i < length; i++) {
/* Ignore the variables used to instruct the loader into
- * behaving differently, as they could throw the tests off. */
- if (!STRPREFIX(newenv[i], "LD_"))
+ * behaving differently, as they could throw the tests off.
+ * Also ignore __CF_USER_TEXT_ENCODING, which is set by MacOS. */
s/MacOS/macOS/ (in the commit message too)
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization