Re: [libvirt] [PATCH v2] test: fix nwfilter tests following changes in virfirewall.c

On Sun, Dec 21, 2014 at 10:52:39AM -0500, Stefan Berger wrote: > On 11/26/2014 11:53 AM, Eric Blake wrote: >> On 11/26/2014 09:26 AM, Stefan Berger wrote: >>> Some of the nwfilter tests are now failing since --concurrent shows >>> up in the ebtables command. To avoid this, implement a function >>> preventing the probing for lock support in the eb/iptables tools >>> and use it in the tests. >> Now that I've read Martin and Prerna's exchange, I'm wondering if we >> should instead make this override force the locking flags ON, and >> adjust >> the expected test output to expect the -w/--concurrent. >> > > Either this or the other patch should have made it into v1.2.11... > I was under the impression that it did. As I said earlier, changing tests to always use concurrent is a long run, not a simple "sed -i ..." or something. And I don't feel like it's of a huge importance as I, for example, have around 3 other tests failing when building as root.