On 06/01/2012 02:45 PM, Marti Raudsepp wrote:
On Fri, Jun 1, 2012 at 10:30 PM, Eric Blake <eblake@redhat.com> wrote:
Once you get down to no args, it's more efficient to do:
virCommandNew(emulator);
And one BIIIIG problem - making this change means that 'make check' fails, unless you update ALL of the tests to match.
Thankfully, we had very few named VMs in our testsuite - I only had to touch 15 files.
Oops, obviously I'm new to libvirt development. :)
ACK with those modifications, so I will push once I complete the testsuite conversion. I will also be adding you to AUTHORS; let me know if you prefer a different spelling than what you used to make your commit.
Thanks, this ID is good.
Good to know. Pushed now. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org