On 09/27/2016 08:24 AM, Martin Kletzander wrote:
The old ivshmem is deprecated in QEMU, so let's use the better ivshmem-{plain,doorbell} variants instead.
Perhaps explained a bit differently (my understanding ;-))... Older versions of qemu had one type (ivshmem - the current default), but newer versions of qemu will force selection of a specific type using "plain" or "doorbell" as the model type depending on which "features" are desired (??) [fill in the details] I guess the nagging question is - what happens if someone "chooses" to have <model type='ivshmem'> in this newer world? Does the deprecation from qemu kick in and the domain cannot start? We should note that somehow/somewhere.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- docs/schemas/domaincommon.rng | 2 ++ src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 ++ src/qemu/qemu_command.c | 7 +++++++ 4 files changed, 14 insertions(+), 1 deletion(-)
docs/formatdomain.html.in needs to change here too In particular what constitutes each setting - that is are there XML elements that would or wouldn't make sense for the type of shmem device (I'm thinking of Daniel's table here). BTW: When using your "Since" tags, it'll need to be clear which version of qemu no longer supports "type='ivshmem'" and forces someone to choose -plain or -doorbell. ACK w/ the doc change John