On 07/02/2014 03:51 AM, Nicholas A. Bellinger wrote:
Hi Mike & Co,
Can we please keep the libvirt names consistent for virtio-scsi parameters with what is already defined in qemu..? (Paolo CC'ed)
From qemu/include/hw/virtio/virtio-scsi.h:
#define DEFINE_VIRTIO_SCSI_PROPERTIES(_state, _conf_field) \ DEFINE_PROP_UINT32("num_queues", _state, _conf_field.num_queues, 1), \
This one is already exposed as 'queues' and it has been in a few libvirt releases - changing it would break compatibility.
DEFINE_PROP_UINT32("max_sectors", _state, _conf_field.max_sectors, 0xFFFF),\ DEFINE_PROP_UINT32("cmd_per_lun", _state, _conf_field.cmd_per_lun, 128)
These are the attribute names I just pushed. Jan
AFAICT, having different names between qemu + libvirt parameters can only add confusion.
--nab