Re: [libvirt PATCH 4/4] qemu: Enable migration events only for fresh QEMU process
On Thu, May 12, 2022 at 14:07:10 +0200, Jiri Denemark wrote:
On Thu, May 12, 2022 at 13:32:38 +0200, Peter Krempa wrote:
> On Thu, May 12, 2022 at 13:30:57 +0200, Jiri Denemark wrote:
[....]
> > I guess the migration would just hang waiting for an event
that never
> > comes. But I guess it should be fairly easy to check whether events are
> > enabled before starting a migration and report an error instead of
> > hanging.
>
> Leaving the VM in a hanging migration would be bad, but if we can just
> refuse it I'd be okay with that.
Actually, doing so would not make any sense. We could just as easy
enable the capability on reconnect if it's not enabled. Which is the
alternative solution I described above in the Notes section :-)
I think I'm also starting to lean towards the fact that "This can't
happen" and simply ignore it ;) ... I'm not sure if I:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
It somewhere else in this thread.