Re: [libvirt] [PATCH] Revert "storageVolCreateXMLFrom: Check if backend knows how to createVol"

On Mon, Feb 15, 2016 at 09:11:13 +0100, Ján Tomko wrote:

This reverts commit 611a278fa46d3136b7fe5c6ab05e660ca3c8fdf4.

According to the original commit message, this is dead code:

It is highly unlikely that a backend will know how to create a volume from a different volume (buildVolFrom) and not know how to create an empty volume (createVol). --- src/storage/storage_driver.c | 7 ------- 1 file changed, 7 deletions(-)

ACK, rather than this pointless check, it would be better just to note it in the storage driver structure that backend->createVol is a prerequisite for storageVolCreateXMLFrom. This is something a developer should be aware and is of no use to a user. Also a developer will get the crash when developing it. Peter